Skip to content

fix: preserve non-enumerable properties in cached results #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mixelburg wants to merge 1 commit into from
+11 −4
Closed

fix: preserve non-enumerable properties in cached results #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,23 @@ function matter(input, options) {
if (cached) {
file = Object.assign({}, cached);
file.orig = cached.orig;
file.matter = cached.matter;
file.language = cached.language;
return file;
}
}

const result = parseMatter(file, options);

// only cache if there are no options passed. if we cache when options
// are passed, we would need to also cache options values, which would
// negate any performance benefits of caching
// only cache if there are no options passed. if we cache when options
// are passed, we would need to also cache options values, which would
// negate any performance benefits of caching.
// Cache after parseMatter succeeds so invalid front-matter is not cached (fixes #166).
if (!options) {
matter.cache[file.content] = file;
}

return parseMatter(file, options);
return result;
}

/**
Expand Down