IstioOperator Manifest Causes Crash#64
Open
ljluestc wants to merge 4 commits into
Open
Conversation
Owner
|
Thanks for adding this @ljluestc I pushed a commit removing some redundant logic and adding an additional case to the test. I see you've left this in draft, was there something else you were going to add here? If not I'm happy to merge it. |
- Fixed null metadata handling in yamlToHCL function to prevent panic when processing IstioOperator manifests without metadata - Updated TestYAMLToTerraformResourcesMapOnly to properly test mapOnly=true functionality - Added TestYAMLToHCLIstioOperatorStripNull test to verify IstioOperator manifest processing - All tests now pass including race condition checks - Resolves issue jrhouston#62: IstioOperator Manifest Causes Crash
- Restored comment for ignoreMetadata variable - Restored comment for ignoreAnnotations variable - Restored inline comments for empty document handling - Restored original flag descriptions - All tests still pass after comment restoration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
panic: value is nullcrash when processing theIstioOperatormanifest (issue #62) by adding thestripNullFieldsfunction to remove null values from YAML manifests. It also fixes failing tests and adds validation for theIstioOperatorcase.Changes:
stripNullFieldsfunction to recursively remove null fields when--strip-nullis used.TestYAMLToHCLStripNullto use four-space indentation, matchingterraform.FormatValueoutput.TestYAMLToTerraformResourcesMapOnlyto setmapOnly=trueand updated expected HCL.TestYAMLToHCLIstioOperatorStripNullto verify theIstioOperatormanifest is processed correctly.make test.Testing:
make testto confirm all tests pass.