build: Bump oci-spec to 0.10.0#167
Merged
Merged
Conversation
cgroups-rs exposes oci-spec types in its public API (e.g. Manager::set() takes &LinuxResources), so the version pinned here dictates which oci-spec version every consumer must use: 0.x lines are semver-incompatible, and a consumer on a newer oci-spec gets "expected LinuxResources, found LinuxResources" type mismatches. Kata Containers is moving its workspace to oci-spec 0.10.0 and cannot call into cgroups-rs until this crate follows. The 0.8 to 0.10 changes are additive for everything cgroups-rs touches (no code changes needed): the crate builds warning-free with the oci feature and the unit tests pass (the only failures are the pre-existing fs manager tests that need root to write cgroupfs). Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com> Assisted-by: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the optional oci-spec dependency version used by the oci feature so downstream consumers can align on a single oci-spec 0.10.x type set when cgroups-rs exposes OCI types in its public API.
Changes:
- Bump
oci-specfrom0.8.1to0.10.0(optional dependency).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
burgerdev
reviewed
Jul 9, 2026
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
Shouldn't there be lock file changes?
Author
|
New zbus and zvariant releases require a newer Rust compiler. Use Rust 1.90.0 in CI so dependency resolution can complete. Signed-off-by: Tim Zhang <tim@hyper.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgroups-rs exposes oci-spec types in its public API (e.g. Manager::set() takes &LinuxResources), so the version pinned here dictates which oci-spec version every consumer must use: 0.x lines are semver-incompatible, and a consumer on a newer oci-spec gets "expected LinuxResources, found LinuxResources" type mismatches.
Kata Containers is moving its workspace to oci-spec 0.10.0 and cannot call into cgroups-rs until this crate follows. The 0.8 to 0.10 changes are additive for everything cgroups-rs touches (no code changes needed): the crate builds warning-free with the oci feature and the unit tests pass (the only failures are the pre-existing fs manager tests that need root to write cgroupfs).