fix: allow timer jitter in TestForwarderConnectionRetryAndTimeout#1696
Open
Fedosin wants to merge 1 commit into
Open
fix: allow timer jitter in TestForwarderConnectionRetryAndTimeout#1696Fedosin wants to merge 1 commit into
Fedosin wants to merge 1 commit into
Conversation
The test asserts that a 500ms context timeout does not return early, but Go timers can fire slightly before the deadline on busy CI runners. Add a 5ms tolerance to prevent sub-millisecond drift from causing flaky failures. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves CI reliability by making TestForwarderConnectionRetryAndTimeout tolerant to small Go timer jitter, avoiding spurious failures when context deadlines fire a fraction of a millisecond early on busy runners.
Changes:
- Introduces a small
timerJitterduration constant in the test. - Adjusts the minimum elapsed-time assertion from
>= requestTimeoutto>= requestTimeout - timerJitter. - Updates the assertion message to reflect approximate timing expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestForwarderConnectionRetryAndTimeoutsets a 500ms context timeoutand then asserts
elapsed >= 500ms. On busy CI runners Go timers canfire slightly before the deadline — the failing run saw
499.495ms.Add a 5ms tolerance so sub-millisecond timer drift does not cause
spurious failures.
Example of a failed test.
Checklist
README.md, keda-docs)Fixes #