Tag validation#23
Open
masihyeganeh wants to merge 5 commits into
Open
Conversation
Author
|
Correct me if I'm wrong, but based on this example: Data-Structures DEFINITIONS ::=
BEGIN
DataStructures ::= SEQUENCE
{
int INTEGER,
limitedString UTF8String (SIZE(1..16)),
optionalString UTF8String OPTIONAL,
enumerated ENUMERATED {value1, value2, value3},
optionalChoice CHOICE
{
int1 [0] INTEGER,
int2 [1] INTEGER
} OPTIONAL,
sequenceOfString SEQUENCE OF UTF8String
}
ENDin places such as Other than that, it should always be |
Author
|
OK, I just added ability to parse |
Owner
|
FYI: as long as (existing) tests do not pass, I do not consider a PR as ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now validates tags.
It shows that
C::TAGis wrong sometimes. we need to work on that.simple_dernow panics withGot unexpected tag Universal(2) instead of ContextSpecific(0)error.It needs to parse a Number (
Universal(2)) butC::TAGsays it needs to seeContextSpecific(0)that is wrong.And by the way, I added more default tags and implemented
Displayfor it if you don't mind.