-
Notifications
You must be signed in to change notification settings - Fork 304
feat(datasets): support multimodal dataset items #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ed19fe4
feat(api): update generated dataset media API
wochinge cd791b6
feat(datasets): support media references
wochinge a9a4a96
fix(datasets): address media review feedback
wochinge 2c6718a
fix(datasets): refine media review fixes
wochinge 592f9de
Merge remote-tracking branch 'origin/main' into feature/lfe-10289-pyt…
wochinge 3832a4e
fix(datasets): clean up media review follow-ups
wochinge 88905ce
fix(datasets): round-trip resolved media references
wochinge d7eb3ed
fix(datasets): process media inside tuples and sets
wochinge 7db0fe7
fix(datasets): align media reference field with expectedOutput API re…
wochinge a2cba12
fix(datasets): drop tuple media support to avoid namedtuple breakage
wochinge 0e2ea09
fix(media): honor per-client httpx config for media reference fetches
wochinge 310f692
feat(datasets): scope media uploads to their dataset item
wochinge dcb3fc7
Merge remote-tracking branch 'origin/main' into feature/lfe-10289-pyt…
wochinge 6c0d12c
fix(datasets): resolve dataset id once per create_dataset_item
wochinge d4e08f2
fix(datasets): url-encode dataset name and fix media upload job fixture
wochinge e40e8ea
refactor(datasets): collect media in one pass, resolve dataset id lazily
wochinge 4e0a12d
refactor(media): rename url_is_expired to is_url_expired
wochinge 378f767
feat(datasets): always resolve dataset item media references
wochinge 47ca159
refactor(datasets): hand-roll media reference JSONPath, drop jsonpath-ng
wochinge 6ad46e5
test(media): use fixed timestamps so is_url_expired ids are xdist-stable
wochinge 5ad0c3d
refactor(datasets): namespace json_path import, drop stale -OO comment
wochinge b21b83a
Merge branch 'main' into feature/lfe-10289-python-sdk-changes
wochinge ac89d9a
chore(api): take dataset/session generated code from main
wochinge 752a718
Merge remote-tracking branch 'origin/main' into feature/lfe-10289-pyt…
wochinge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wochinge marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wochinge marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.