Skip to content

MPI shared memory socket scope#1072

Open
kab163 wants to merge 13 commits into
developfrom
task/add-mpi3-socket-scope
Open

MPI shared memory socket scope#1072
kab163 wants to merge 13 commits into
developfrom
task/add-mpi3-socket-scope

Conversation

@kab163

@kab163 kab163 commented May 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@kab163 kab163 marked this pull request as ready for review May 11, 2026 22:55
@kab163 kab163 requested a review from davidbeckingsale May 12, 2026 17:36
@kab163 kab163 requested review from adayton1 and rhornung67 June 1, 2026 21:33
Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp
Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp Outdated
Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp Outdated
Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp Outdated
adayton1
adayton1 previously approved these changes Jun 3, 2026
@adayton1

adayton1 commented Jun 3, 2026

Copy link
Copy Markdown
Member

Would it be worth considering adding hwloc as a dependency to get the socket info?

@kab163

kab163 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Would it be worth considering adding hwloc as a dependency to get the socket info?

I think it would be worth considering... I think for now we should merge this and see how people like it. If there's a need/desire to add hwloc later, we can. (Maybe as an optional dependency - like use hwloc if detected, otherwise use the linux system calls/numa like the branch does now.)

Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp Outdated
Comment thread src/umpire/resource/HostMpi3SharedMemoryResource.cpp Outdated
@kab163

kab163 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Update: Hubcast doesn't understand jobs that are allowed to fail. We can either fix the job failure or try to fix within Hubcast somehow.. stay tuned

@adayton1

adayton1 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Update: Hubcast doesn't understand jobs that are allowed to fail. We can either fix the job failure or try to fix within Hubcast somehow.. stay tuned

You'll need to update branch protections under settings -> branches -> develop and list the CI jobs that are required to pass (instead of ci/gitlab.lc.llnl.gov).

@kab163

kab163 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Update: Hubcast doesn't understand jobs that are allowed to fail. We can either fix the job failure or try to fix within Hubcast somehow.. stay tuned

You'll need to update branch protections under settings -> branches -> develop and list the CI jobs that are required to pass (instead of ci/gitlab.lc.llnl.gov).

I don't see where I'd be able to do this in the develop branch's settings... (I'm getting copilot to help me...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants