Skip to content

fix(examples/arc): Remove obsolete error handling#205

Open
vadorovsky wants to merge 1 commit into
lvgl:masterfrom
vadorovsky:examples-arc
Open

fix(examples/arc): Remove obsolete error handling#205
vadorovsky wants to merge 1 commit into
lvgl:masterfrom
vadorovsky:examples-arc

Conversation

@vadorovsky

@vadorovsky vadorovsky commented Dec 28, 2025

Copy link
Copy Markdown

Label::set_text and Arc::set_end_angle do not return Result.


Summary by cubic

Removed obsolete error handling in examples/arc by removing the ? operator after Label::set_text and Arc::set_end_angle, which no longer return Result. This fixes build errors and keeps the example in sync with the current API.

Written for commit 6f49efc. Summary will update automatically on new commits.

`Label::set_text` and `Arc::set_end_angle` do not return `Result`.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@C47D

C47D commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the fix @vadorovsky I tested it locally and indeed fix an error, any idea why is the Rust build step failing?

thread 'misc::anim::test::anim_test' (12180) panicked at lvgl/src/misc/anim.rs:118:28:
null pointer dereference occurred

@vadorovsky

vadorovsky commented Jan 7, 2026

Copy link
Copy Markdown
Author

any idea why is the Rust build step failing?

thread 'misc::anim::test::anim_test' (12180) panicked at lvgl/src/misc/anim.rs:118:28:
null pointer dereference occurred

It seems like a separate issue and some unsound usage of pointers. I can try fixing it (in a separate PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants