Skip to content

dts:msm8953:Add wt89536 and qk1505#716

Merged
TravMurav merged 2 commits into
msm8916-mainline:mainfrom
Tikily:msm8953
Jun 25, 2026
Merged

dts:msm8953:Add wt89536 and qk1505#716
TravMurav merged 2 commits into
msm8916-mainline:mainfrom
Tikily:msm8953

Conversation

@Tikily

@Tikily Tikily commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Tikily Tikily changed the title k2nd:dts:msm8956:Add wt89536 and qk1505 k2nd:dts:msm8953:Add wt89536 and qk1505 Jun 16, 2026
Comment thread lk2nd/device/dts/msm8953/msm8953-qrd-sku3.dts Outdated
Comment thread lk2nd/device/dts/msm8953/msm8953-wingtech-wt89536.dts Outdated
Comment thread lk2nd/device/dts/msm8953/msm8953-qrd-sku3.dts Outdated
Comment thread lk2nd/device/dts/msm8953/msm8953-wingtech-wt89536.dts Outdated

@TravMurav TravMurav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would you mind rearranging your history so you have two separate commits adding each device (so first you have commit that adds and documents one device, then one that adds+documents second one)

Comment thread lk2nd/device/dts/msm8953/msm8953-qrd-sku3.dts Outdated
Comment thread lk2nd/device/dts/msm8953/msm8953-wingtech-wt89536.dts Outdated
Comment on lines +38 to +55

360-qk1505 {

/*
* Warning: Bootloader is locked and cannot be unlocked.
* This device requires signed boot images (SIGN_BOOTIMG=1) for booting.
* Flashing an unsigned or non-official image will result in boot failure.
*/

model = "360 N4s";
compatible = "360,qk1505";

lk2nd,dtb-files = "msm8953-360-qk1505";

lk2nd,match-panel;
panel {
compatible = "360,qk1505-panel", "lk2nd,panel";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation still seems to be a bit weird here (i.e. the comment is one indent level below, there are some lines that have stray whitespace (we usually make sure that empty lines have no spaces/tabs on them), and there's still seems to be a mix of tabs and spaces used for indentation, instead of just tabs)

And since this needs one more round, if you can, I'd appreciate if you add marketing name to each commit subject (i.e. dts: msm8953: Add CMCC N2 / YU Yureka2 (wt89536), note the lack of lk2nd: prefix, which we usually omit for dts additions, since there's so many of them usually compared to everything else, so we mark them on their own)

Other than those two nits, I don't see any other obvious issues

Comment on lines +42 to +53

/*
* Warning: Bootloader is locked and cannot be unlocked.
* This device requires signed boot images (SIGN_BOOTIMG=1) for booting.
*/

lk2nd,dtb-files = "msm8953-360-qk1505";
lk2nd,match-panel;

panel {
compatible = "360,qk1505-panel", "lk2nd,panel";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*
* Warning: Bootloader is locked and cannot be unlocked.
* This device requires signed boot images (SIGN_BOOTIMG=1) for booting.
*/
lk2nd,dtb-files = "msm8953-360-qk1505";
lk2nd,match-panel;
panel {
compatible = "360,qk1505-panel", "lk2nd,panel";
/*
* Warning: Bootloader is locked and cannot be unlocked.
* This device requires signed boot images (SIGN_BOOTIMG=1) for booting.
*/
lk2nd,dtb-files = "msm8953-360-qk1505";
lk2nd,match-panel;
panel {
compatible = "360,qk1505-panel", "lk2nd,panel";

Try kate for the text editor?

@Tikily Tikily changed the title k2nd:dts:msm8953:Add wt89536 and qk1505 dts:msm8953:Add wt89536 and qk1505 Jun 22, 2026
Comment thread lk2nd/device/dts/msm8953/msm8953-qrd-sku3.dts Outdated
@Tikily Tikily force-pushed the msm8953 branch 2 times, most recently from 7d8180b to b4749e4 Compare June 24, 2026 03:03
@Tikily Tikily closed this Jun 24, 2026
@Tikily Tikily reopened this Jun 24, 2026
@TravMurav TravMurav merged commit 6c0eb2a into msm8916-mainline:main Jun 25, 2026
42 checks passed
@TravMurav

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants