dts:msm8953:Add wt89536 and qk1505#716
Conversation
TravMurav
left a comment
There was a problem hiding this comment.
Also would you mind rearranging your history so you have two separate commits adding each device (so first you have commit that adds and documents one device, then one that adds+documents second one)
|
|
||
| 360-qk1505 { | ||
|
|
||
| /* | ||
| * Warning: Bootloader is locked and cannot be unlocked. | ||
| * This device requires signed boot images (SIGN_BOOTIMG=1) for booting. | ||
| * Flashing an unsigned or non-official image will result in boot failure. | ||
| */ | ||
|
|
||
| model = "360 N4s"; | ||
| compatible = "360,qk1505"; | ||
|
|
||
| lk2nd,dtb-files = "msm8953-360-qk1505"; | ||
|
|
||
| lk2nd,match-panel; | ||
| panel { | ||
| compatible = "360,qk1505-panel", "lk2nd,panel"; | ||
|
|
There was a problem hiding this comment.
The indentation still seems to be a bit weird here (i.e. the comment is one indent level below, there are some lines that have stray whitespace (we usually make sure that empty lines have no spaces/tabs on them), and there's still seems to be a mix of tabs and spaces used for indentation, instead of just tabs)
And since this needs one more round, if you can, I'd appreciate if you add marketing name to each commit subject (i.e. dts: msm8953: Add CMCC N2 / YU Yureka2 (wt89536), note the lack of lk2nd: prefix, which we usually omit for dts additions, since there's so many of them usually compared to everything else, so we mark them on their own)
Other than those two nits, I don't see any other obvious issues
|
|
||
| /* | ||
| * Warning: Bootloader is locked and cannot be unlocked. | ||
| * This device requires signed boot images (SIGN_BOOTIMG=1) for booting. | ||
| */ | ||
|
|
||
| lk2nd,dtb-files = "msm8953-360-qk1505"; | ||
| lk2nd,match-panel; | ||
|
|
||
| panel { | ||
| compatible = "360,qk1505-panel", "lk2nd,panel"; | ||
|
|
There was a problem hiding this comment.
| /* | |
| * Warning: Bootloader is locked and cannot be unlocked. | |
| * This device requires signed boot images (SIGN_BOOTIMG=1) for booting. | |
| */ | |
| lk2nd,dtb-files = "msm8953-360-qk1505"; | |
| lk2nd,match-panel; | |
| panel { | |
| compatible = "360,qk1505-panel", "lk2nd,panel"; | |
| /* | |
| * Warning: Bootloader is locked and cannot be unlocked. | |
| * This device requires signed boot images (SIGN_BOOTIMG=1) for booting. | |
| */ | |
| lk2nd,dtb-files = "msm8953-360-qk1505"; | |
| lk2nd,match-panel; | |
| panel { | |
| compatible = "360,qk1505-panel", "lk2nd,panel"; | |
Try kate for the text editor?
7d8180b to
b4749e4
Compare
|
Thanks! |
No description provided.