fix: handle image_rename_map key mismatch in colmap_to_json (issue #3759)#3761
Closed
vanhci wants to merge 1 commit into
Closed
fix: handle image_rename_map key mismatch in colmap_to_json (issue #3759)#3761vanhci wants to merge 1 commit into
vanhci wants to merge 1 commit into
Conversation
) COLMAP stores image names relative to the reconstruction directory (e.g. 'images/rig1/front/imageN.jpg'), but image_rename_map keys are relative to the data directory (e.g. 'rig1/front/imageN.jpg'). This mismatch caused a KeyError when using nested image hierarchies with rigs. Fix by trying both the direct lookup and stripping the 'images/' prefix, with a descriptive error message if neither matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3759
When using COLMAP with nested image hierarchies (e.g., cube rigs with multiple cameras per face),
colmap_to_jsonraises aKeyErrorbecause COLMAP stores image names with theimages/prefix (e.g.,images/rig1/front/imageN.jpg) whileimage_rename_mapkeys are relative to the data directory (e.g.,rig1/front/imageN.jpg).Changes
colmap_to_jsoninnerfstudio/process_data/colmap_utils.pyto try both the direct lookup and theimages/prefix-stripped lookupTesting
This is a runtime fix for a KeyError in COLMAP image rename mapping. The fix handles both flat and nested image directory structures gracefully.