fixes #25419; lift magic types to typeclasses#25425
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Fixes #25419; lift magic types to typeclasses
fixes #25419; lift magic types to typeclasses
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed PR changes that prevent compilation errors when user-defined procedures shadow magic type names like
seq,array, etc.Changes
tyUncheckedArrayto the set of magic types{tySet, tyArray, tySequence}that are lifted totyBuiltInTypeClasswhen their element type istyNoneelementTypeaccessor for cleaner type child accesstyOpenArrayandtyVarargsremain excluded (special-cased at line 1657 to not receivetyNonechildren)Example
The fix ensures magic generics are properly represented as typeclasses during semantic analysis, preventing shadowing conflicts.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.