Add warning for integer literals exceeding 64-bit capacity in non-base-10 formats#25447
Closed
Copilot wants to merge 3 commits into
Closed
Add warning for integer literals exceeding 64-bit capacity in non-base-10 formats#25447Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
Member
|
@copilot fixes it for all int types insteaf of restricting it to |
…simplify condition Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix long integer literal truncation without warning
Add warning for integer literals exceeding 64-bit capacity in non-base-10 formats
Jan 20, 2026
Copilot stopped work on behalf of
ringabout due to an error
January 20, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long integer literals in hex/binary/octal formats are silently truncated to 64 bits, masking potential bugs when developers expect larger values.
Changes
compiler/lexer.nim:
result.baseearly during first-stage parsing (enables proper warning context)tkIntLit,tkUIntLit) after suffix determinationtests/lexer/tinteger_literal_no_overflow.nim:
Example
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.