Conversation
…rmaid rendering - Add emoji to all section headers in index.pl.md to match English version - Add missing 'User Interface Overview' section to Polish docs - Reorder sections to match consistent structure between EN and PL - Fix Mermaid rendering by moving from extra.javascript to extra_javascript - Add mermaid-init.js for proper initialization with theme detection - Improve Mermaid theme switching based on Material color scheme
- Remove duplicate 'Jak To Działa' section - Add missing emoji to Examples (📋) and Contributing (🤝) sections - Add complete Contributing section with full content - Add License section with fork attribution - Add footer banner (myEmbeddedWay) - Synchronize Polish version structure with English version - Fix section hierarchy and improve readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues in the test suite and adds new functionality to the GUI, along with documentation updates. The changes ensure better code reliability and user experience.
Key Changes:
🧪 Test Suite Fixes:
Fixed AttributeError in ModbusParser by initializing self.bufferIndex = 0 in the init method to prevent failures in handler methods.
Corrected imports in GUI tests (e.g., QStyleOptionViewItem from QtWidgets instead of QtGui).
Added proper mocking for serial.Serial in tests to avoid real hardware access and ensure test isolation.
Updated assertions in parser tests (e.g., removed problematic assertions and added bufferIndex initialization) and GUI add_parsed_data method to use safe .get() for optional fields.
Configured pytest in pyproject.toml to measure coverage on source code (src) instead of the installed package, improving accuracy (coverage now at 95%).
🚀 Feature Enhancements:
📚 Documentation Updates:
Improved Polish documentation pages with standardized emojis, added missing UI section, and fixed Mermaid rendering.
Added application screenshots and fixed references to the main icon file.
Reorganized and fixed the structure of the Polish index page.
General documentation improvements and updates for better clarity.
Testing:
All 63 tests now pass successfully.
Code coverage is at 95%, with no regressions introduced.
Impact:
These changes improve the robustness of the test suite, add valuable user-facing features, and enhance documentation quality. The project is ready for the next release.
Related Commits: bd7b294, fdd21a2, 5352ff1, 8f15a86, 71651ef, fe9cb28, 10797e0, 9581aea, f730887
Closes: #7