feat: add experimental view_matching_mode to meter provider#666
Draft
dashpole wants to merge 1 commit into
Draft
feat: add experimental view_matching_mode to meter provider#666dashpole wants to merge 1 commit into
dashpole wants to merge 1 commit into
Conversation
6 tasks
There was a problem hiding this comment.
Pull request overview
Adds an experimental meter_provider.view_matching_mode/development configuration option to support composable View matching (per spec work), and propagates it through the schema outputs, docs, and language support metadata.
Changes:
- Add
view_matching_mode/developmentto the MeterProvider schema (enum values:independent,composable) and regenerate JSON schema + docs. - Update per-language support metadata to mark the new property as
not_implemented. - Add a validator shelltest for invalid values and update an example configuration to demonstrate usage.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| validator/shelltests/invalid_view_matching_mode.yaml | New negative test input using an invalid view_matching_mode/development value. |
| validator/shelltests/invalid_view_matching_mode.test | Expected validator output for the invalid value case. |
| schema/meter_provider.yaml | Introduces view_matching_mode/development on MeterProvider. |
| schema/meta_schema_language_php.yaml | Marks the new MeterProvider property as not_implemented for PHP. |
| schema/meta_schema_language_js.yaml | Marks the new MeterProvider property as not_implemented for JS. |
| schema/meta_schema_language_java.yaml | Marks the new MeterProvider property as not_implemented for Java. |
| schema/meta_schema_language_go.yaml | Marks the new MeterProvider property as not_implemented for Go. |
| schema/meta_schema_language_cpp.yaml | Marks the new MeterProvider property as not_implemented for C++. |
| schema-docs.md | Documents the new property and its language support status (generated). |
| opentelemetry_configuration.json | Adds the generated JSON schema for the new property. |
| language-support-status.md | Updates generated language support tables to include the new property. |
| examples/otel-sdk-config.yaml | Demonstrates view_matching_mode/development: composable plus views. |
| CHANGELOG.md | Notes the new property in Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…property Implements composable View matching configuration in support of open-telemetry/opentelemetry-specification#5173. - Adds experimental meter_provider.view_matching_mode/development property ('independent' default, 'composable') - Marks view_matching_mode/development as not_implemented in language support status matrix - Updates existing otel-sdk-config.yaml example and adds validator shelltest edge case
dashpole
force-pushed
the
add-view-matching-mode
branch
from
5225b23 to
0e8eb3d
Compare
dashpole
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements composable View matching configuration in support of open-telemetry/opentelemetry-specification#5173.
Adds experimental meter_provider.view_matching_mode/development enum property, with ['independent' default, 'composable'] as values