feat: add podantiaffinity and nodeaffinity

[zdtsw]

• operator pod must run on Linux node
• preferrable operator pods with label name:opendatahub-operator should not run on the same node

Description

ref: https://issues.redhat.com/browse/RHOAIENG-28127

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Refactor
  • Updated pod scheduling rules to ensure operator pods are scheduled only on Linux nodes and to prefer distributing pods across different nodes for improved reliability.

[coderabbitai]

## Walkthrough

Affinity and anti-affinity scheduling rules were added to the Open Data Hub operator's controller manager pod deployment specifications in both the ClusterServiceVersion manifest and the manager deployment YAML. These changes ensure pods are scheduled only on Linux nodes and prefer to run on separate nodes from other operator pods.

## Changes

| File(s)                                                                 | Change Summary                                                                                          |
|-------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------|
| bundle/manifests/opendatahub-operator.clusterserviceversion.yaml,       | Added node affinity (Linux-only) and preferred pod anti-affinity (spread across nodes) to pod spec.     |
| config/manager/manager.yaml                                             | Enhanced pod spec with node affinity (Linux-only) and preferred pod anti-affinity (spread across nodes). |

## Suggested labels

`lgtm`

## Suggested reviewers

- pierDipi
- bartoszmajsak

## Poem

> 🐇  
> Pods now hop from node to node,  
> Preferring not to share their abode.  
> Only on Linux fields they graze,  
> Spreading wide in Kubernetes' maze.  
> With affinity rules, they leap anew—  
> Operator bunnies, strong and true!  
>

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8050648 and ff5e124.

📒 Files selected for processing (2)

• bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (2 hunks)
• config/manager/manager.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
• config/manager/manager.yaml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zdtsw]

cc @bdattoma who is not in this org

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

config/manager/manager.yaml (1)

30-49: Optional: add zone-level spreading for greater resilience
To further minimise blast radius on multi-zone clusters you could append a second preferredDuringSchedulingIgnoredDuringExecution entry that uses topologyKey: topology.kubernetes.io/zone. This keeps the rule soft while nudging the scheduler to spread replicas across zones when they exist.

bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (1)

1301-1320: Minor consistency nit: align key ordering with kustomize manifest
Here the list item has podAffinityTerm before weight, whereas the kustomize file places weight first. Functionally identical, but keeping the ordering consistent across files reduces noise in future diffs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 439ff3a and 8050648.

📒 Files selected for processing (2)

• bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (2 hunks)
• config/manager/manager.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build/push catalog image
• GitHub Check: Run tests and collect coverage
• GitHub Check: golangci-lint

🔇 Additional comments (2)

config/manager/manager.yaml (1)

30-49: Affinity block correctly enforces Linux-only scheduling and soft anti-collocation
The node-affinity uses the canonical kubernetes.io/os=linux selector and the pod anti-affinity (weight 100) discourages multiple opendatahub-operator pods on the same node. YAML structure matches the Kubernetes schema.

bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (1)

1301-1320: CSV manifest faithfully mirrors the new affinity rules – nice catch
Propagating the same node- and pod-affinity into the CSV ensures the OLM-managed deployment behaves exactly like the kustomize manifest.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ugiordan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ugiordan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.29%. Comparing base (439ff3a) to head (ff5e124).
Report is 33 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   36.29%   36.29%           
=======================================
  Files          85       85           
  Lines        7754     7754           
=======================================
  Hits         2814     2814           
  Misses       4680     4680           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zdtsw]

/cherry-pick rhoai

[openshift-cherrypick-robot]

@zdtsw: #2079 failed to apply on top of branch "rhoai":

Applying: feat: add podantiaffinity and nodeaffinity
Using index info to reconstruct a base tree...
A	bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
M	config/manager/manager.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/manager/manager.yaml
Auto-merging bundle/manifests/rhods-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/rhods-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: add podantiaffinity and nodeaffinity

Details

In response to this:

/cherry-pick rhoai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.