Add vonage video api support by haocheng2023 · Pull Request #845 · opentok/opentok-rtc

haocheng2023 · 2023-11-27T18:12:49Z

No description provided.

Requires Node 14+. Fixes fixes missing connection data in web client.

And remove incorrect info in README about precall test not being supported.

Unsupported for Vonage applications, currently

…support

jeffswartz

This PR appears to disable the use of OpenTok credentials and require Vonage credentials (if we target the master branch). Do we want to create a new vonage-application-support branch (or whatever we want to call it), and have this PR target that branch? Or do we want to change this PR so that it lets you use either OpenTok or Vonage credentials (based on the environment variables on the system)?

jeffswartz

This PR appears to disable the use of OpenTok credentials and require Vonage credentials (if we target the master branch). Do we want to create a new vonage-application-support branch (or whatever we want to call it), and have this PR target that branch? Or do we want to change this PR so that it lets you use either OpenTok or Vonage credentials (based on the environment variables on the system)?

jeffswartz · 2023-11-30T21:34:20Z

-export TB_API_KEY=<key>
-export TB_API_SECRET=<secret>
+export VONAGE_APPLICATION_ID=<application-id>
+export VONAGE_PRIVATE_KEY=<private-key>


The code uses VONAGE_PRIVATE_KEY_PATH, right? I actually think VONAGE_PRIVATE_KEY is better, because this can be a path to a private key or the actual private key String, right? If so, please change throughout.

jeffswartz · 2023-11-30T21:35:33Z

-      },
+      }
    );
  }


Lots of linting errors (here and in other files). Please run npm run lint.

jeffswartz · 2023-12-01T01:57:26Z

+// E.OPENTOK_PRECALL_API_KEY = { envVar: 'TB_PRECALL_API_KEY', jsonPath: 'precallTest.apiKey' };

-E.OPENTOK_PRECALL_API_SECRET = { envVar: 'TB_PRECALL_API_SECRET', jsonPath: 'precallTest.apiSecret' };
+// E.OPENTOK_PRECALL_API_SECRET = { envVar: 'TB_PRECALL_API_SECRET', jsonPath: 'precallTest.apiSecret' };


So, I guess we're using the same app ID and secret for the precall session. That makes sense. I think it was a mistake early to have the app use a separate API key and secret for the precall session. (It should use a separate session ID.)

jeffswartz · 2023-12-04T14:40:00Z

      const credentials = new Auth({
        applicationId,
-        privateKey: privateKeyPath,
+        privateKey: privateKey,


Suggested change

privateKey: privateKey,

privateKey,

jeffswartz · 2023-12-04T14:43:46Z

+You can set the `VONAGE_APPLICATION_ID` and `VONAGE_PRIVATE_KEY` environment variables to
+your Vonage application ID and private key. For example, the following shell commands export
+these values for use by the app (replace `<application-id>` and `<private-key>` with your
+Vonage application ID and private key):


Suggested change

Vonage application ID and private key):

Vonage application ID and either the private key or path to the private key):

jeffswartz · 2023-12-04T14:44:43Z

-For example, the following shell commands export these values for use by the app
-(replace `<key>` and `<secret>` with your OpenTok API key and the corresponding API secret):
+You can set the `VONAGE_APPLICATION_ID` and `VONAGE_PRIVATE_KEY` environment variables to
+your Vonage application ID and private key. For example, the following shell commands export


Suggested change

your Vonage application ID and private key. For example, the following shell commands export

your Vonage application ID and private key (or path to the private key). For example, the following shell commands export

joliveraortega · 2024-01-16T11:19:59Z

@jeffswartz or @haocheng2023 Is anything here left?, can this be merged in?, will this get to master branch? Please, advise. Thanks.

jeffswartz and others added 22 commits August 16, 2022 10:43

Initial work for Vonage application support

70818c6

README edits for Vonage application

203dd2a

Update @vonage/video version

710ba3a

Change the Vonage Video web client URL

6935ecc

API tests for Vonage applications

ea8f4a4

README info on OpenTok.js URL (to https://unpkg.com/@vonage...)

4c08e1d

update to latest @vonage/video SDK

aa34771

Requires Node 14+. Fixes fixes missing connection data in web client.

Remove separate App ID for precall test

7eb6561

And remove incorrect info in README about precall test not being supported.

Disable SIP in UI

75a6a24

Unsupported for Vonage applications, currently

Remove unused OpenTok server SDK mock

760688c

Remove unneeded console.log() call

4cfb614

Fix API tests (for calls to Vonage Video server SDK)

209bb48

More test fixes

88e3d72

Change API key and API secret to app ID and private key

9f70391

Fix for ChatController test stubs

f837c13

Fix call to Vonage server SDK sendSignal() method

3c09d54

Rev version to 5.0, and fix node version in package.json

57d8812

Fix deleteArchive()

5cc5557

Remove unneeded console.log() call

0bdada4

Merge remote-tracking branch 'origin/master' into vonage-application-…

9a9c650

…support

rev version

7db22d9

Add vonage video api support

cfae979

jeffswartz suggested changes Nov 27, 2023

View reviewed changes

haocheng2023 changed the base branch from master to vonage-application-support November 29, 2023 21:47

jeffswartz changed the base branch from vonage-application-support to vonage November 29, 2023 22:27

opentok deleted a comment from haocheng2023 Nov 29, 2023

haocheng2023 added 3 commits November 29, 2023 15:45

merge

9b48acc

merge

a5fcebe

whitesource check

0cbc25e

jeffswartz suggested changes Dec 1, 2023

View reviewed changes

jeffswartz reviewed Dec 1, 2023

View reviewed changes

haocheng2023 added 3 commits December 1, 2023 10:28

lint

ca75eae

change vonage private key path to vonage private key

de06b1d

change vonage private key path to vonage private key

0ad370c

haocheng2023 force-pushed the vonage branch 4 times, most recently from d6cb102 to 0ad370c Compare December 1, 2023 19:51

jeffswartz reviewed Dec 4, 2023

View reviewed changes

jeffswartz approved these changes Dec 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add vonage video api support#845

Add vonage video api support#845
haocheng2023 wants to merge 28 commits into
opentok:vonagefrom
haocheng2023:vonage

haocheng2023 commented Nov 27, 2023

Uh oh!

jeffswartz left a comment

Uh oh!

jeffswartz left a comment

Uh oh!

jeffswartz Nov 30, 2023

Uh oh!

jeffswartz Nov 30, 2023

Uh oh!

jeffswartz Dec 1, 2023

Uh oh!

jeffswartz Dec 4, 2023

Uh oh!

jeffswartz Dec 4, 2023

Uh oh!

jeffswartz Dec 4, 2023

Uh oh!

joliveraortega commented Jan 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Vonage application ID and private key):
	Vonage application ID and either the private key or path to the private key):

	your Vonage application ID and private key. For example, the following shell commands export
	your Vonage application ID and private key (or path to the private key). For example, the following shell commands export

Uh oh!

Conversation

haocheng2023 commented Nov 27, 2023

Uh oh!

jeffswartz left a comment

Choose a reason for hiding this comment

Uh oh!

jeffswartz left a comment

Choose a reason for hiding this comment

Uh oh!

jeffswartz Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

jeffswartz Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

jeffswartz Dec 1, 2023

Choose a reason for hiding this comment

Uh oh!

jeffswartz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

jeffswartz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

jeffswartz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

joliveraortega commented Jan 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants