Skip to content

Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers#10411

Open
Monviech wants to merge 1 commit into
masterfrom
deprecate-safepoint
Open

Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers#10411
Monviech wants to merge 1 commit into
masterfrom
deprecate-safepoint

Conversation

@Monviech

Copy link
Copy Markdown
Member

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

If AI was used, please disclose:

  • Model used:
  • Extent of AI involvement:

Describe the problem

Fixes: #10235

…ft, and we don't know of any external API consumers
@Monviech Monviech self-assigned this Jun 12, 2026
@Monviech Monviech added the cleanup Low impact changes label Jun 12, 2026

@fichtner fichtner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually we need to put a more generic mechanism in place, but we can discuss this for a roadmap item in the future

@fichtner

Copy link
Copy Markdown
Member

There's still

plist:/usr/local/opnsense/scripts/filter/rollback_cancel.php
plist:/usr/local/opnsense/scripts/filter/rollback_timer.php

along with the configd action definitions

@AdSchellevis

Copy link
Copy Markdown
Member

We might be able to create some facility combined with a generic mvc pattern to identify changes (which should show the apply button), but there will likely be constraints (not all models are capable of tracking modifications currently). The persisted_at attribute is part of the puzzle here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Low impact changes

Development

Successfully merging this pull request may close these issues.

Firewall: Deprecate and remove savepoint actions

3 participants