Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers#10411
Open
Monviech wants to merge 1 commit into
Open
Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers#10411Monviech wants to merge 1 commit into
Monviech wants to merge 1 commit into
Conversation
…ft, and we don't know of any external API consumers
fichtner
approved these changes
Jun 17, 2026
fichtner
left a comment
Member
There was a problem hiding this comment.
eventually we need to put a more generic mechanism in place, but we can discuss this for a roadmap item in the future
Member
|
There's still along with the configd action definitions |
Member
|
We might be able to create some facility combined with a generic mvc pattern to identify changes (which should show the apply button), but there will likely be constraints (not all models are capable of tracking modifications currently). The persisted_at attribute is part of the puzzle here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Fixes: #10235