Refactor masonry class component to function component#83
Open
rodrigovcortezi wants to merge 3 commits into
Open
Refactor masonry class component to function component#83rodrigovcortezi wants to merge 3 commits into
rodrigovcortezi wants to merge 3 commits into
Conversation
DDeme
approved these changes
Apr 12, 2022
DDeme
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Took the time to refactor this amazing masonry component to a function component using react hooks. As the react community seems to be moving to this direction, I belive this is an important refactoring, specially considering the future of this project’s maintainability.
The component’s API stays untouched, and changes to the code have been made in a way changes were kept as minimal as possible.