Update unicode-display_width dependency#61
Conversation
Support using v3 of unicode-display_width, inline with rubocop, so that we're not forcing users to downgrade
piotrmurach
left a comment
There was a problem hiding this comment.
Thank you for this PR!
I'm all for relaxing the constraints on the unicode-display_width gem to allow for newer versions.
In a strict sense, the current constraints don't require any downgrade action on the user unless they are intent on using the very lastest unicode-display_width gem version. Usually, this is a transitory dependency, and most users probably don't use it directly.
I'd also appreciate a change note in the changelog. This can be under ## unreleased and ### Changed headings.
Co-authored-by: Piotr Murach <pmurach@gmail.com>
True, however as a maintainer of an app that handles PII, it's always best to have all dependencies be on the latest version with security/bug fixes. Requiring a downgrade for a dependency in order to install latest versions of something we need is not an ideal compromise.
Done |
piotrmurach
left a comment
There was a problem hiding this comment.
Nice one! The changelog entry needs some editing.
Co-authored-by: Piotr Murach <pmurach@gmail.com>
Co-authored-by: Piotr Murach <pmurach@gmail.com>
|
@piotrmurach Hey. Friendly reminder :-) We're going through our SOC2 audit again and need to explain outdated dependencies, so having this constraint eased would be most helpful. |
Describe the change
Support using v3 of unicode-display_width
Why are we doing this?
Inline with rubocop requirements, so that we're not forcing users to downgrade
Benefits
Allow users of tty-progressbar to use latest gem versions
Drawbacks
None known
Requirements
masterbranch?