ROB: Guard text operators against missing operands in extract_text#3861
Merged
Conversation
stefan6419846
approved these changes
Jun 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3861 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 55 55
Lines 10509 10510 +1
Branches 1958 1958
=======================================
+ Hits 10277 10278 +1
Misses 128 128
Partials 104 104 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crash on text operators with missing operands
A malformed content stream whose
",TD,TdorTfoperator supplies fewer operands than the operator needs makesextract_text()raise an uncaughtIndexError(the"case can also surface as aValueError), because the operands are read by fixed index with no arity check. Guarded each access where it is read so a short operator is skipped or falls back to a zero translation, matching theif operands elsehandling already used on the neighbouring text-state operators.