substitute RCPP_UNORDERED_MAP with std::unordered_map#74
Open
Enchufa2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear jiebaR maintainer,
As part of the effort to clean up old code and set C++11 as the baseline standard for Rcpp (see RcppCore/Rcpp#1365), we identified that this package is using
RPP_UNORDERED_MAP, and we would like to suggest substituting this define with the properstd::unordered_maptype. In this way, we would be able to remove this unnecessary define without breaking your package on CRAN.We would appreciate if you could merge this PR and send an update to CRAN at your earliest convenience.
Thanks,
On behalf of the Rcpp Core Team