Show request details in popup modal#750
Conversation
5295862 to
0c29808
Compare
| const iGps = 6 | ||
| const iSummary = 7 | ||
|
|
||
| window.onload = function() { |
There was a problem hiding this comment.
Since we use jQuery, change this window.onload to
$(window).on('load', function(){
})There was a problem hiding this comment.
Thanks,
But we can't do that because jquery script is loaded at the bottom of the page. using $ would through an error
There was a problem hiding this comment.
Ah okay..
Then changing it to window.addEventListener would be good enough. I saw in other places window.onload is been used. It will cause the onload overridden from other places.
There was a problem hiding this comment.
chaged to window.addEventListener, though overriding won't be an issue as only one template is loaded at a time
realslimshanky
left a comment
There was a problem hiding this comment.
LTGM. It would be better if you place CSS and JS in their respective files in static.
|
@shanavas786 please resolve conflicts as well. |
d8e2d8c to
280d348
Compare
|
done |
realslimshanky
left a comment
There was a problem hiding this comment.
Please squash your commits. Rest LGTM.
Use eventlistener instead of onload
b795c6b to
7836017
Compare

Issue Reference
This PR addresses the Issue : Closes #626
Summarize
By handling request detail in request list page itself, we can reduce hits to request details api