Skip to content

build.py: updated path normalization for .js files [windows]#613

Open
sfinktah wants to merge 1 commit into
rgthree:mainfrom
sfinktah:sfink-simple-build-fix-windows
Open

build.py: updated path normalization for .js files [windows]#613
sfinktah wants to merge 1 commit into
rgthree:mainfrom
sfinktah:sfink-simple-build-fix-windows

Conversation

@sfinktah

@sfinktah sfinktah commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

This is the one-line fix for the issue with building on Windows. The one that created ../../../../../../../../app.js paths.

-   rel_path = file.replace(f'{DIR_WEB}/', "")
+   rel_path = os.path.relpath(file, DIR_WEB)

This avoids the excessive changes in #609.

The declarations in comfy/frontend do still need to be made exportable, but there is probably a more appropriate place to deal with that.

@sfinktah

Copy link
Copy Markdown
Contributor Author

@rgthree any change of expiditing this one? it's an absolute pain to have to patch manually for every PR.

... of course, you could probably do with less PRs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant