Apply identity default Bcc in compose#1976
Open
keilogic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442
Summary
default_bccfield to the profile editor create/update flowTests
npx ng test --include src/app/compose/draftdesk.service.spec.ts --watch=false --browsers=FirefoxHeadlessfailed as expected with the new default-Bcc expectations (TOTAL: 3 FAILED, 22 SUCCESS).npx ng test --include src/app/compose/draftdesk.service.spec.ts --watch=false --browsers=FirefoxHeadless(TOTAL: 25 SUCCESS)npx tsc -p src/tsconfig.app.json --noEmitnpx tsc -p src/tsconfig.spec.json --noEmitnpm run lint -- --quietnpm run policy(passes for these commits; still reports existing historical upstream commit-message warnings)git diff --check origin/master...HEADSKIP_CHANGELOG=1production build sequence:node src/build/pre-build.js,npx ng build --configuration production --base-href=/app/ runbox7,node src/build/post-build.js(build hash68316653f4a23fc8; existing Angular/CommonJS/theming warnings)The regression tests are in a separate commit from the implementation commit.
AI disclosure
I used OpenAI Codex as an AI coding assistant to inspect the relevant compose/profile code, implement the patch, and run the validation commands listed above.