Add support for any-value and valueless query param redirect rules#2460
Merged
acelaya merged 4 commits intoJul 17, 2025
Merged
Conversation
344a5e7 to
18c4c39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2460 +/- ##
=============================================
+ Coverage 93.68% 93.69% +0.01%
- Complexity 1730 1744 +14
=============================================
Files 279 279
Lines 5934 5948 +14
=============================================
+ Hits 5559 5573 +14
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2386
This PR adds two new redirect rule conditions that expand and add more flexibility over the existing
query-paramcondition.any-value-query-param: will match as soon as the query string contains a specific parameter, regardless of its value or even if it has no value at all.valueless-query-param: will match if the query string contains a specific parameter but with no value at all (for examplehttps://example.com/?fooorhttps://example.com/?foo=)