Allow trusted proxies to be provided via TRUSTED_PROXIES env var or config option#2461
Merged
Merged
Conversation
acelaya
force-pushed
the
feature/trusted-proxies
branch
from
165e21e to
3318987
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2461 +/- ##
==========================================
Coverage 93.69% 93.69%
Complexity 1744 1744
==========================================
Files 279 279
Lines 5948 5948
==========================================
Hits 5573 5573
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2360
This PR allows trusted proxies to be defined, disabling the workaround introduced in #2359, and using the proper mechanisms supported by akrabat/ip-address-middleware instead.
This also deprecates the workaround, which will be removed in Shlink 5.0.0