Make Tera Blast show up as Usually Useless for formats it's banned in#2692
Open
23PLevinJ wants to merge 1 commit into
Open
Make Tera Blast show up as Usually Useless for formats it's banned in#269223PLevinJ wants to merge 1 commit into
23PLevinJ wants to merge 1 commit into
Conversation
23PLevinJ
changed the title
Member
|
This should probably check for: is Gen 9, does not have |
Author
|
how would i implement those edits? |
Member
|
Hm, I suppose there's no easy way to call the ruleTable to check it. Probably would he something for another PR? |
Author
|
yeah maybe |
| return (!moves.includes('flareblitz') && !moves.includes('pyroball') && !moves.includes('sacredfire') && | ||
| !moves.includes('bitterblade') && !moves.includes('firepunch')) || this.isDoubles; | ||
| case 'terablast': | ||
| return !(dex.gen === 9 && !this.formatType && ['ou', 'uu', 'ru', 'nu', 'pu', 'zu'].includes(format)); |
Member
There was a problem hiding this comment.
This logic is reversed
Contributor
There was a problem hiding this comment.
Also, it would be better if this actually pulled from the formats where tera blast is banned through some kind of code logic instead of hardcoding them.
Member
There was a problem hiding this comment.
that is what the rest of the conversation was. its on my to-do list but shouldnt stop this from merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://www.smogon.com/forums/threads/add-tera-blast-to-usually-useless-if-tera-is-not-available-in-the-meta.3783114/