Skip to content

Recognize Champions VGC as doubles in teambuilder #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abkwreu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Recognize Champions VGC as doubles in teambuilder #2695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions play.pokemonshowdown.com/src/battle-dex-search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@
this.formatType = 'champions';
this.dex = Dex.mod('champions' as ID);
format = format.slice(9) as ID;
if (format.startsWith('vgc')) this.isDoubles = true;
if (format.startsWith('vgc') || format.startsWith('bss')) format = 'ubers' as ID;

@DaWoblefet DaWoblefet Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should just not have the VGC check. The next if statement already is supposed to set the appropriate format and the isDoubles flag.

@KrisXV KrisXV Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this check doesnt exist then the format will show CAP pokemon, so idk

}
if (format.startsWith('vgc')) {
Expand Down Expand Up @@ -1100,7 +1101,7 @@
}
let tierSet: SearchRow[] = table.tierSet;
let slices: { [k: string]: number } = table.formatSlices;
if (format === 'ubers' || format === 'uber' || format === 'ubersuu' || format === '4v4doublesuu' || format === 'nationaldexdoubles') {

Check warning on line 1104 in play.pokemonshowdown.com/src/battle-dex-search.ts

View workflow job for this annotation

GitHub Actions / build (22.x) 

This line has a length of 134. Maximum allowed is 120
tierSet = tierSet.slice(slices.Uber);
} else if (isVGCOrBS || (isHackmons && dex.gen === 9 && !this.formatType)) {
if (format.endsWith('series13') || format.endsWith('regj') || isHackmons) {
Expand Down
Loading