Skip to content

Support -brokeprotect#2701

Open
iforgetwhyimhere wants to merge 2 commits into
smogon:masterfrom
iforgetwhyimhere:zbroken
Open

Support -brokeprotect#2701
iforgetwhyimhere wants to merge 2 commits into
smogon:masterfrom
iforgetwhyimhere:zbroken

Conversation

@iforgetwhyimhere

Copy link
Copy Markdown
Member

Client dependency for recognizing changes in smogon/pokemon-showdown#12107

@pyuk-bot

Copy link
Copy Markdown
Contributor

What’s the message for moves that fully remove Protect for the rest of the turn like Feint?

@urkerab

urkerab commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

You need to retain support for the old protocol because of replays (and other reasons).

@iforgetwhyimhere

Copy link
Copy Markdown
Member Author

You need to retain support for the old protocol because of replays (and other reasons).

Yeah, I realized that overnight. Fixed now.

What’s the message for moves that fully remove Protect for the rest of the turn like Feint?

"POKEMON fell for the feint!" Is what Feint uses, but other moves like Hyperspace Hole/Fury and Shadow Force use "It broke through [TARGETS]'s protection!" as an |-activate|. Same case with other moves that bypass protect. This code handles specifically Protect not fully blocking, but reducing, the damage taken.

@iforgetwhyimhere iforgetwhyimhere changed the title Replace -zbroken with -brokeprotect Support -brokeprotect Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants