Champions: Add Natures from OTS to tooltips#2705
Open
ShivaD173 wants to merge 5 commits into
Open
Conversation
ShivaD173
changed the title
iforgetwhyimhere
suggested changes
Jun 21, 2026
iforgetwhyimhere
left a comment
iforgetwhyimhere
left a comment
Member
There was a problem hiding this comment.
LGTM + small nitpick
ShivaD173
force-pushed
the
natures-tooltip
branch
from
bad8ab1 to
28a2683
Compare
iforgetwhyimhere
approved these changes
Jun 21, 2026
Member
|
This is an excellent change, but if we're going to account for Speed on the tooltips for +/- Speed natures, we should do it for neutral Natures too. For example, this Ninetales is Timid, and it correctly displays the 141-177 range: This Kingambit is Adamant, so it should show a range of 70-102, not 63-112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Natures from OTS to tooltips. Displays known speed range based on nature.
