Fix incorrect CPU float16 implementation#2395
Open
eliasachermann wants to merge 4 commits into
Open
Conversation
Remove print statement indicating all tests passed.
ThrudPrimrose
requested changes
Jun 8, 2026
ThrudPrimrose
left a comment
Collaborator
There was a problem hiding this comment.
We need subnormal, inf and NaN in roundtrip tests to ensure we handle them correctly.
| 1e-3, | ||
| 6e-5, | ||
| 6e-8, | ||
| -6e-8, |
Collaborator
There was a problem hiding this comment.
Can you add a subnormal number to your tests?
ThrudPrimrose
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
dace::halffallback indace/runtime/include/dace/types.his broken in two independent ways:No default constructor.
Generated code that declares an uninitialized
dace::float16fails to compile:Incorrect conversions.
The float↔half conversion is wrong for zero, subnormals, Inf/NaN, and does no rounding.
Fix
Tests
Adds
tests/half_cpu_test.py, to test the conversion against NumPy as the reference.