Release: Prerelease 10.5.0-alpha.10#35302
Open
github-actions[bot] wants to merge 60 commits into
Open
Conversation
…snippets Closes #23208 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Avoid re-collapsing chrome and re-applying filters on in-review navigation.
Centralize unseen/visited/notified tracking, auto-accept on review routes, and notification slot deduplication in sessionStorage.
Track deferred review payloads internally and expose a notificationKey so notification effects re-run when displayed or pending reviews change.
Defer superseding review updates, sync notification state to the store, and clear arrival notifications on dismiss or pending accept.
Surface new reviews via the manager notification API instead of auto-navigating away from the user's current canvas.
Replace auto-navigation on review push with the notification layer.
…pdates Use the shared review store for the widget title and navigate via the canonical review summary entry helper.
Reset the review store between stories, stabilize createdAt fixtures, align assertions with Update navigation and router-based widget opens, and wait for notification effects before asserting on mocks.
The story mocked addNotification without rendering NotificationList, so the canvas showed no notification despite the play test passing. Use a harness that mirrors sidebar notification state and assert the visible headline.
Thumbnail previews on the review summary emitted STORY_SPECIFIED, which the manager treated as canvas navigation and replaced the URL. Treat review routes as non-canvas and keep review viewMode in the main layout so the summary stays mounted.
Contributor
Author
- Added new test cases to verify onClick behavior with default prevention. - Refactored handleClick to ensure onClick is called before navigation. - Introduced utility functions for creating click events and retrieving onClick handlers.
…efore-trigger Addon-Vitest: Subscribe for run completion before triggering it
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
af63ab9 to
8ac9670
Compare
…-query-docs Docs: Clarify TanStack Query client tradeoffs
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
8ac9670 to
ae2f045
Compare
…t-config VSCode: Do not reference removed config files
…checklist UI: Hide onboarding menu with feature flag
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
ae2f045 to
f9020e8
Compare
…ed-hovered A11y: Surface required args and keyboard-reachable Setup controls in ArgsTable
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
f9020e8 to
a8483ff
Compare
The merge from next dropped hasActiveFilters from story-index-filters but left the import in stories.ts, breaking core:compile:production.
- Updated loaders to log actions for next/link. - Added new test suite for next/link to verify link action logging on click. - Introduced a new story for Link component to trigger link action.
…pdate. Record the notified slot when a review is accepted and read pending state from the store at click time so layout-effect sync cannot re-post the sidebar toast.
Deferred superseding pushes on review routes already surface the Update banner, so suppress the sidebar notification and sync pending state to the store immediately.
Review: Notify on review arrival instead of auto-navigating
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
a8483ff to
69ae851
Compare
…onclick-order Next: Call link onClick before preventing default
storybook-bot
force-pushed
the
version-non-patch-from-10.5.0-alpha.9
branch
from
69ae851 to
02247f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from `10.5.0-alpha.9` to `10.5.0-alpha.10`.
Once this pull request is merged, it will trigger a new release of version `10.5.0-alpha.10`.
If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to `next`, that will be part of this release:
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.5.0-alpha.10