Stop cleanupNumericValues from changing id attributes breaking refs#2220
Open
mattaw wants to merge 1 commit into
Open
Stop cleanupNumericValues from changing id attributes breaking refs#2220mattaw wants to merge 1 commit into
mattaw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the plugin
cleanupNumericValueswas breaking .svg diagrams generated by wavedrom.com.Wavedrom uses the
idstring "000" for one of its repeated elements (a waveform element for logic zero that started as zero, was zero, and finished as zero, hence "000").cleanupNumericValueswas treatingidas a normal number, and truncating "000" to "0", breaking the diagram.This PR adds attributes named
idto the existing exclusion forversionincleanupNumericValuesavoiding this problem. It passesyarn run qa, with a decent number of expected mismatches now listed as matching - maybe this fixed more than just my usecase? See attached terminal logcorepack_yarn_run_qa.log.
Original Diagram:
Broken after svgo default plugin run:
Fixed after patch:
