fix(removeUnknownsAndDefaults): keep attributes referenced by attribute selectors#2226
Open
mahirhir wants to merge 1 commit into
Open
fix(removeUnknownsAndDefaults): keep attributes referenced by attribute selectors#2226mahirhir wants to merge 1 commit into
mahirhir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2144 made this plugin keep an attribute when its value equals the default and it's referenced by an attribute selector such as
[preserveAspectRatio]. That guard only landed in the "default value" branch.The same loop deletes attributes in two other branches: unknown attributes, and attributes that redundantly override an inherited value. Neither one looks at the stylesheet, so both still remove attributes that a selector relies on.
For example, running only this plugin on:
rect'sfill="blue"repeats the parent value, so theuselessOverridesbranch drops it,rect[fill]stops matching, and the rect loses its stroke. A custom attribute used as a styling hook ([state]) runs into the same thing through the unknown-attribute branch.This applies the existing
includesAttrSelectorcheck to all three branches instead of just one. Added a test fixture covering the two cases that weren't handled.