Skip to content

fix(quick-quote): disable selection actions in native mode#658

Merged
urzeye merged 2 commits into
mainfrom
fix/quick-quote-native-mode
Jun 17, 2026
Merged

fix(quick-quote): disable selection actions in native mode#658
urzeye merged 2 commits into
mainfrom
fix/quick-quote-native-mode

Conversation

@urzeye

@urzeye urzeye commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the issue where native mode sites (ChatGPT, Claude, Grok, Qianwen) still show Ophel's quick quote selection popover, which conflicts with their native quote/reply functionality.

Changes

  • Modified canUseQuickQuoteSelectionActions to only enable selection actions in enabled mode
  • Updated QuickQuoteSupportMode documentation to clarify the three modes:
    • enabled: Ophel fully manages (both selection popover and reference chips)
    • native: Site has native quote feature, Ophel stays out (both disabled to avoid conflicts)
    • disabled: Site doesn't support, Ophel technically can't either (both disabled)

Test Plan

  • Verified that selection popover no longer appears on ChatGPT, Claude, Grok, and Qianwen
  • Confirmed that selection popover still works on other sites (Gemini, etc.)
  • Build passes successfully

urzeye added 2 commits June 18, 2026 01:24
Sites with native quick quote support (ChatGPT, Claude, Grok,
Qianwen) should not show Ophel's selection popover at all, even
when prompt chains are available. This ensures Ophel doesn't
interfere with the site's native quote/reply functionality.
Update QuickQuoteSupportMode documentation to clarify:
- enabled: Ophel fully manages (both popover and chips)
- native: Site has native quote feature, Ophel stays out
- disabled: Site doesn't support, Ophel technically can't either

Selection popover and reference chips use the same logic.
@urzeye urzeye self-assigned this Jun 17, 2026
@urzeye urzeye added the bug Something isn't working label Jun 17, 2026
@urzeye urzeye added this to the v1.1.0 milestone Jun 17, 2026
@urzeye urzeye merged commit b4c07be into main Jun 17, 2026
1 check passed
@urzeye urzeye deleted the fix/quick-quote-native-mode branch June 17, 2026 17:31
@github-project-automation github-project-automation Bot moved this from Todo to Done in Ophel Development Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant