feat(offcanvas): added new module offcanvas. by SvetlanaMuravlova · Pull Request #6424 · valor-software/ngx-bootstrap

SvetlanaMuravlova · 2022-01-26T08:10:54Z

feat(offcanvas): added new module offcanvas.

…strap into offcanvas-module

github-actions · 2022-01-27T10:36:58Z

Visit the preview URL for this PR (updated for commit 09612d1):

https://ngx-bootstrap-demo--pr6424-offcanvas-module-0p77flqn.web.app

_{(expires Mon, 10 Oct 2022 13:37:09 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

codecov · 2022-01-27T10:39:14Z

Codecov Report

Merging #6424 (dcf04aa) into development (0380c3c) will increase coverage by 0.22%.
The diff coverage is 57.89%.

❗ Current head dcf04aa differs from pull request most recent head 85d15bf. Consider uploading reports for the commit 85d15bf to get more accurate results

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #6424      +/-   ##
===============================================
+ Coverage        76.42%   76.64%   +0.22%     
===============================================
  Files              315      314       -1     
  Lines            10613    10568      -45     
  Branches          2924     2918       -6     
===============================================
- Hits              8111     8100      -11     
+ Misses            2501     2467      -34     
  Partials             1        1

Impacted Files	Coverage Δ
src/modal/modal-container.component.ts	`44.15% <0.00%> (+6.49%)`	⬆️
src/modal/public_api.ts	`100.00% <ø> (ø)`
src/modal/modal.directive.ts	`3.66% <12.50%> (-0.42%)`	⬇️
src/modal/bs-modal.service.ts	`88.28% <100.00%> (+19.70%)`	⬆️
src/modal/modal.module.ts	`84.61% <100.00%> (-1.10%)`	⬇️
src/tooltip/tooltip.directive.ts	`57.04% <100.00%> (ø)`
src/chronos/i18n/it.ts	`80.00% <0.00%> (-20.00%)`	⬇️
src/chronos/i18n/uk.ts	`87.50% <0.00%> (-3.13%)`	⬇️
src/chronos/i18n/cs.ts	`88.42% <0.00%> (ø)`
src/chronos/i18n/pl.ts	`88.52% <0.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0380c3c...85d15bf. Read the comment docs.

cypress · 2022-01-27T11:17:54Z

Test summary

806 • 32 • 14 • 0

Run details


Project	ngx-bootstrap
Status	Failed
Commit	`9d3ff03` ℹ️
Started	Oct 3, 2022 1:38 PM
Ended	Oct 3, 2022 2:10 PM
Duration	31:30 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 100

View run in Cypress Dashboard ➡️

Failures

	typeahead_page_spec.ts	1
1	Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
	datepicker/locales_spec.ts	2
1	Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2	Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
	modals_service_page_spec.ts	7
1	Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2	Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3	Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4	Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5	Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6	Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7	Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 32 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

valorkin · 2022-01-28T11:22:36Z

  @HostListener('click', ['$event'])
  onClickStop(event: MouseEvent): void {
    const clickedInBackdrop = event.target === this._element.nativeElement && !this.clickStartedInContent;
+    console.log(clickedInBackdrop);


Suggested change

console.log(clickedInBackdrop);

console.log(clickedInBackdrop);

valorkin · 2022-01-28T11:47:27Z

+export class OffcanvasContainerComponent {
+  _config?: typeof OffcanvasConfig;
+  id = id++;
+  @ViewChild(OffcanvasDirective, {static: false}) public directive?: OffcanvasDirective;


Suggested change

@ViewChild(OffcanvasDirective, {static: false}) public directive?: OffcanvasDirective;

@ViewChild(OffcanvasDirective, {static: false}) public offcanvasDirective?: OffcanvasDirective;

valorkin · 2022-01-28T11:48:36Z

+@Directive({selector: '[offcanvas]', exportAs:'offcanvas'})
+export class OffcanvasDirective {
+  isOpen = false;
+  delayValue = 300; // it is necessary for showing several elements


Suggested change

delayValue = 300; // it is necessary for showing several elements

// it is necessary for showing several elements

delayValue = 300;

valorkin · 2022-01-28T11:49:43Z

+  backdropScrolling: boolean;
+};
+
+export const OffcanvasConfig: OffcanvasConfigType = {


should be injectable

valorkin · 2022-01-28T11:50:05Z

+
+  @Input() set config(value: OffcanvasConfigType | undefined) {
+    if (!value) {
+      this.config = Object.assign({}, OffcanvasConfig);


inject OffcanvasConfig as service, to allow app module configuration

valorkin · 2022-01-28T11:50:45Z

+  _config?: OffcanvasConfigType;
+
+  @Input() set config(value: OffcanvasConfigType | undefined) {
+    if (!value) {


just use as a value
const config = Object.assign({}, OffcanvasConfig, this.offcanvasConfig, value || {})

valorkin · 2022-01-28T11:52:58Z

@@ -0,0 +1,18 @@
+export type AvailablePlacement = 'start' | 'end' | 'top' | 'bottom';
+export type OffcanvasConfigType = {


…moved backdrop into component-loader, added offcanvas for bs4

github-actions · 2022-12-05T11:11:04Z

Visit the preview URL for this PR (updated for commit 85d15bf):

https://ngx-bootstrap-demo--pr6424-offcanvas-module-x2gqtwla.web.app

_{(expires Mon, 12 Dec 2022 11:11:00 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07}

SvetlanaMuravlova added 3 commits January 24, 2022 14:22

feat(offcanvas): added offcanvas module for bs5

c9e1f69

feat(offcanvas): updated examples

a2b4b85

feat(offcanvas): added preview

7a5d8aa

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 08:11 Inactive

test commit

9a181a1

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 12:52 Inactive

test commit

ce29600

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 12:53 Inactive

SvetlanaMuravlova added 2 commits January 27, 2022 12:17

feat(offcanvas): added unite tests

22cdbbd

Merge branch 'offcanvas-module' of github.com:valor-software/ngx-boot…

237e933

…strap into offcanvas-module

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 10:22 Inactive

fix(offcanvas): fix build

e9556dc

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 10:31 Inactive

feat(offcanvas): added e2e tests

798c506

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 14:59 Inactive

SvetlanaMuravlova changed the title ~~Offcanvas module~~ feat(offcanvas): added new module offcanvas. Jan 27, 2022

fix(offcanvas): fix lint

0d5f48c

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 07:54 Inactive

fix(offcanvas): updated angular.json

420a990

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 08:33 Inactive

valorkin reviewed Jan 28, 2022

View reviewed changes

feat(offcanvas): api installation

8281d2e

valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 12:22 Inactive

SvetlanaMuravlova and others added 7 commits February 18, 2022 13:34

feat(offcanvas): added injectable for config, renamed some elements, …

305d1b2

…moved backdrop into component-loader, added offcanvas for bs4

fix(e2e tests): fixed e2e tests after updates

a8ad22b

feat(offcanvas): updates in structure

5cdb570

feat(offcanvas): added text

8deb2e3

pass text updates

ffd7987

fix(test): fixed unite tests for offcanvas

b479f8a

Merge branch 'development' into offcanvas-module

c0995f3

atheros mentioned this pull request Aug 8, 2022

Boostrap 5 Offcanvas support #6375

Open

SvetlanaMuravlova and others added 3 commits September 23, 2022 12:09

merge commit

4bf4535

Merge branch 'development' into offcanvas-module

09612d1

fake commit

85d15bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(offcanvas): added new module offcanvas.#6424

feat(offcanvas): added new module offcanvas.#6424
SvetlanaMuravlova wants to merge 22 commits into
developmentfrom
offcanvas-module

SvetlanaMuravlova commented Jan 26, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 27, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Jan 27, 2022 •

edited

Loading

Uh oh!

cypress Bot commented Jan 27, 2022 •

edited

Loading

Uh oh!

valorkin Jan 28, 2022

Uh oh!

valorkin Jan 28, 2022

Uh oh!

valorkin Jan 28, 2022

Uh oh!

valorkin Jan 28, 2022

Uh oh!

valorkin Jan 28, 2022

Uh oh!

valorkin Jan 28, 2022 •

edited

Loading

Uh oh!

valorkin Jan 28, 2022

Uh oh!

github-actions Bot commented Dec 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	console.log(clickedInBackdrop);
	console.log(clickedInBackdrop);

	@ViewChild(OffcanvasDirective, {static: false}) public directive?: OffcanvasDirective;
	@ViewChild(OffcanvasDirective, {static: false}) public offcanvasDirective?: OffcanvasDirective;

	delayValue = 300; // it is necessary for showing several elements
	// it is necessary for showing several elements
	delayValue = 300;

		@@ -0,0 +1,18 @@
		export type AvailablePlacement = 'start' \| 'end' \| 'top' \| 'bottom';
		export type OffcanvasConfigType = {

Uh oh!

Conversation

SvetlanaMuravlova commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cypress Bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test summary

Run details

Failures

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valorkin Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SvetlanaMuravlova commented Jan 26, 2022 •

edited

Loading

github-actions Bot commented Jan 27, 2022 •

edited

Loading

codecov Bot commented Jan 27, 2022 •

edited

Loading

cypress Bot commented Jan 27, 2022 •

edited

Loading

valorkin Jan 28, 2022 •

edited

Loading