fix(dom): guard against null document.head in copyStyleSheetsToWindow#9203
Open
okxint wants to merge 1 commit into
Open
fix(dom): guard against null document.head in copyStyleSheetsToWindow#9203okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
When the target window (e.g. a Picture-in-Picture window) is closing or in an invalid state, win.document.head can be null. Appending to a null node throws an uncaught TypeError. Resolve the insertion target once before iterating: prefer document.head, fall back to documentElement, and bail out early if neither is available. Fixes videojs#9186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
win.document.headis null, theappendChildcall throws. Resolved the insertion target once before the loop (head || documentElement) and bail early if neither is available.Closes #9186