Skip to content

Making sure that the default credentials chain is used for S3 authentication#15

Open
kujon wants to merge 2 commits into
wal-g:masterfrom
kujon:aws_credentials_chain
Open

Making sure that the default credentials chain is used for S3 authentication#15
kujon wants to merge 2 commits into
wal-g:masterfrom
kujon:aws_credentials_chain

Conversation

@kujon

@kujon kujon commented Feb 13, 2020

Copy link
Copy Markdown

Addresses wal-g/wal-g#562

@x4m

x4m commented Feb 14, 2020

Copy link
Copy Markdown

@perekalov can you please take a look here?
Basically, I understand that all removed code is trying to do S3 SDK's job, but... it is doing it in a different way.

@kujon

kujon commented Feb 14, 2020

Copy link
Copy Markdown
Author

@x4m I still need to get it to work first 😅 I'm new to golang, so it's taking a while.

@kujon

kujon commented Feb 17, 2020

Copy link
Copy Markdown
Author

Seems to be working ok rn, based on my limited set of test conditions.

@kujon kujon marked this pull request as ready for review February 17, 2020 22:15
@x4m

x4m commented Feb 18, 2020

Copy link
Copy Markdown

we are currently considering moving storages back under github/wal-g/wal-g
so that storages would be tests with regular WAL-G CI too. If this hapens, will it be problematic for you to move your PR there?

@kujon

kujon commented Feb 18, 2020

Copy link
Copy Markdown
Author

not at all.

@usernamedt

Copy link
Copy Markdown
Member

Hi!

This repository is going to be merged into the wal-g main repo. Please submit any future updates to the main repository.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants