Skip to content

fix(tooling): fix jest setup for UI testing#460

Merged
Shreyas281299 merged 6 commits into
webex:ccwidgetsfrom
Shreyas281299:fix-test-setup
May 26, 2025
Merged

fix(tooling): fix jest setup for UI testing#460
Shreyas281299 merged 6 commits into
webex:ccwidgetsfrom
Shreyas281299:fix-test-setup

Conversation

@Shreyas281299

@Shreyas281299 Shreyas281299 commented May 23, 2025

Copy link
Copy Markdown
Contributor

COMPLETES # https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6271

This pull request addresses

  • We changed how tasklist is being store, initially it was coming from store and then we changed for it to come from SDK
  • This is file since we were mocking the ui and helper both it didnt show any error but if you look at the diff it actually required changes
  • With the new changes that I have done we dont have to mock UI in our tests and actually let the component render to ensure that the mock data that we are pasing is correct in the test. This will ensure our tests to be accurate and actually catch errors

by making the following changes

The major change made is in the tooling for babel and jest

  • Renamed .babelrc -> babel.config.js (recomended by jes)

  • Moved jest config from package.json to jest.config.js

  • Added transformIgnorePatterns to transpile the UI libraries (@momentum-design and MRV2)

  • Removed all the UI mocks and UI element mocks from the tests

  • Fixed any broken mockData to ensure that tests are passing

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@coderabbitai

coderabbitai Bot commented May 23, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Shreyas281299 Shreyas281299 changed the title fix(tooling): remove all mocking of UI elements, get more accurate te… fix(tooling): remove all mocking of UI elements, get more accurate tests May 23, 2025
@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-460.d1b38q61t1z947.amplifyapp.com

@Shreyas281299 Shreyas281299 added the validated Indicates that the PR is ready for actions label May 23, 2025
Comment thread jest.config.js Outdated
Comment thread jest.setup.js Outdated
@Shreyas281299 Shreyas281299 changed the title fix(tooling): remove all mocking of UI elements, get more accurate tests fix(tooling): fix jest setup for UI testing May 23, 2025

@rarajes2 rarajes2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's address the comments to keep the info documented so that we later have the context on the changes.

@Shreyas281299 Shreyas281299 added run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels May 26, 2025
@Shreyas281299 Shreyas281299 merged commit 7c4a021 into webex:ccwidgets May 26, 2025
64 of 86 checks passed
github-actions Bot pushed a commit that referenced this pull request May 26, 2025
# [1.28.0-ccwidgets.62](v1.28.0-ccwidgets.61...v1.28.0-ccwidgets.62) (2025-05-26)

### Bug Fixes

* **tooling:** fix jest setup for UI testing ([#460](#460)) ([7c4a021](7c4a021))
@sreenara

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.28.0-ccwidgets.62 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Shreyas281299 Shreyas281299 deleted the fix-test-setup branch September 16, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @ccwidgets run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants