Allow typing date directly into calendar overlay#73
Merged
Conversation
Contributor
I don't have a strong opinion either way. Let's keep what's in the PR and if we or anyone else feel auto-accept is the way to go, we fix it in a follow up PR. If you could fix the clippy error CI reported that'd be awesome. |
Contributor
Author
|
Ok it should be fixed now 👍 |
Contributor
|
Yep, thanks! I'll release a new version in the next 12 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
When the calendar opens after typing
due:, all keystrokes were consumedby the overlay — the only way to pick a date was keyboard navigation or
shortcuts like
t/T. This PR lets you keep typing: digits, dashes, andbackspace pass through to the draft buffer while the calendar is open, and
the grid tracks the typed date live as it becomes valid.
Changes
calendar was auto-triggered (anchor set), so you can type
due:2027-01-01and have the calendar follow along
in the buffer, so accept produces a single clean token
Note: I left auto-accept out for now, you still press Enter to confirm,
which felt more consistent with the rest of the overlay behavior. Happy to
add it if you'd prefer the calendar close automatically once a valid date
is complete.