Skip to content

Fixes for dart 2 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metacomgd wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for dart 2 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b6cb3f
test version update to latest
metacomgd Sep 21, 2018
2978a13
fix for PI -> pi in dart 2
metacomgd Sep 21, 2018
026a9ca
fix for PI -> pi for dart 2
metacomgd Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/formula/spherical_lawofcosines.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ class Spherical_LawOfCosines {
cos(lat1) * cos(lat2) *
cos(lon2 - lon1)
);
if (distance < 0) distance = distance + PI;
if (distance < 0) distance = distance + pi;

var EarthRadius = 6378137.0; // WGS84 major axis
return EarthRadius * distance;
}
}
}
4 changes: 2 additions & 2 deletions lib/src/great_circle_distance_base.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class GreatCircleDistance {
return Vincenty.distance(this.latitude1, this.longitude1, this.latitude2, this.longitude2);
}

double _radiansFromDegrees(final double degrees) => degrees * (PI / 180.0);
double _radiansFromDegrees(final double degrees) => degrees * (pi / 180.0);

/// A coordinate is considered invalid if it meets at least one of the following criteria:
///
Expand Down Expand Up @@ -94,4 +94,4 @@ class GreatCircleDistance {
throw new FormatException(
"Invalid coordinates at latitude2|longitude2\n$invalidDescription");
}
}
}
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ environment:
# path: ^1.4.1

dev_dependencies:
test: ^0.12.0
test: ^1.3.3