This repository was archived by the owner on Dec 22, 2023. It is now read-only.
Update default number of sections#140
Open
christoff-1992 wants to merge 1 commit into
Open
Conversation
This should be 0 not 1 as we can't assume a value. It can cause issues if the collection view is using headers and footers, as the collection view attempts to dequeue a header/footer that has yet to be registered.
Collaborator
Author
|
@zenangst - il leave this blocked for now, going to do some further testing to make sure no further changes are required / if it affects anything else. |
zenangst
approved these changes
Mar 2, 2020
zenangst
left a comment
zenangst
left a comment
Owner
There was a problem hiding this comment.
@christoff-1992 Looks good to me, merge when you have verified that this is enough :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be 0 not 1 as we can't assume a value. It can cause issues if the collection view is using headers and footers, as the collection view attempts to dequeue a header/footer that has yet to be registered. fixes #139