Skip to content

tests: Add unit tests for zowex package and SSH VSCE integration#4348

Merged
traeok merged 15 commits into
mainfrom
zowex-unit-tests
Jun 24, 2026
Merged

tests: Add unit tests for zowex package and SSH VSCE integration#4348
traeok merged 15 commits into
mainfrom
zowex-unit-tests

Conversation

@traeok

@traeok traeok commented Jun 18, 2026

Copy link
Copy Markdown
Member

Proposed changes

Implements a comprehensive set of unit tests across the zowex-for-zowe-explorer package to validate SSH API behaviors and integration with Zowe Explorer.

Also fixes an issue with the SshUssApi.updateAttributes function where the success flag was never updated to true, as it was default-initialized to false and only later assigned with &&=.

Release Notes

Milestone: 3.6.0

Changelog (for bug fix): Fixed an issue with the updateAttributes function in the SshUssApi class that caused the API's success property to always return false.

(No changelog for tests)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

All checks must pass before this pull request is reviewed by the Zowe Explorer squad.

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish
  • New ZE APIs are tested with extender types that haven't adopted yet to determine breaking changes. Can use Zowe zFTP marketplace extension.

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (23d1713) to head (c1534e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4348      +/-   ##
==========================================
+ Coverage   94.34%   94.82%   +0.47%     
==========================================
  Files         139      146       +7     
  Lines       29745    30740     +995     
  Branches     5658     5904     +246     
==========================================
+ Hits        28064    29149    +1085     
+ Misses       1681     1591      -90     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
zowe-explorer-vsix Download
Build Details
Name Information
PR Commit c1534e1
Merge Commit b8fea58
Size 6.9 MB
Last Updated By traeok
Last Updated Jun 23, 26, 3:28:51 PM UTC
Expires At Sep 21, 26, 3:26:31 PM UTC

@traeok traeok added no-changelog Add to PR's that don't require a CHANGELOG update and removed no-changelog Add to PR's that don't require a CHANGELOG update labels Jun 23, 2026
@traeok traeok marked this pull request as ready for review June 23, 2026 13:46
@github-actions

Copy link
Copy Markdown

📅 Suggested merge-by date: 7/7/2026

@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Jun 23, 2026
@traeok traeok changed the base branch from staging/zowex to main June 23, 2026 15:16
@traeok traeok requested a review from JWaters02 as a code owner June 23, 2026 15:16
awharn and others added 7 commits June 23, 2026 11:22
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok added 7 commits June 23, 2026 11:22
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok force-pushed the zowex-unit-tests branch from 69f8457 to fcc43df Compare June 23, 2026 15:22
Comment thread packages/zowex-for-zowe-explorer/tests/VscePromptApi.test.ts Fixed
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok added the no-changelog Add to PR's that don't require a CHANGELOG update label Jun 23, 2026

@jace-roell jace-roell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @traeok

@pujal0909 pujal0909 self-requested a review June 24, 2026 14:25

@pujal0909 pujal0909 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traeok traeok merged commit c7085ac into main Jun 24, 2026
21 of 25 checks passed
@traeok traeok deleted the zowex-unit-tests branch June 24, 2026 16:21
@github-project-automation github-project-automation Bot moved this from Review/QA to Closed in Zowe Explorer for VS Code Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Add to PR's that don't require a CHANGELOG update size/XXL

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

7 participants