Skip to content

prepare_log_file: update log file creation to use umask for permissions#4807

Open
Martin-Zeithaml wants to merge 3 commits into
v3.x/stagingfrom
v3.x/bugfix/prepareLogs
Open

prepare_log_file: update log file creation to use umask for permissions#4807
Martin-Zeithaml wants to merge 3 commits into
v3.x/stagingfrom
v3.x/bugfix/prepareLogs

Conversation

@Martin-Zeithaml

@Martin-Zeithaml Martin-Zeithaml commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
  1. User can read and write
  2. Group can read - do we want to allow write?
  3. Others no read | write

chmod removed as the file is created with umask & touch.

Used for zwe command, when --log-dir is specified.

./zwe some_command --config zowe.yaml --log-dir /myLogs

ls -al /myLogs

-rw-rw-rw-   1 MARTIN   ZOWEGRP      157 Jun 12 11:05 zwe-some-command-20260612T110543.log  <- old
-rw-r-----   1 MARTIN   ZOWEGRP      157 Jun 12 11:24 zwe-some-command-20260612T112442.log  <- new

Note: prepareLogFile (typescript version) seems to be not used and there is a bug.

…ions

Set umask to restrict permissions when creating log file.

Signed-off-by: Martin Zeithaml <66114686+Martin-Zeithaml@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

build 10529 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/27425788964

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Test workflow 8731 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.5.0-PR-4807/zowe-3.5.0-pr-4807-10529-20260612153744.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/27426100970

@Martin-Zeithaml Martin-Zeithaml marked this pull request as ready for review June 18, 2026 06:51
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

build 10573 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/27742105708

Documented notable changes for version 3.6.0, including bug fixes and enhancements.

Signed-off-by: Martin Zeithaml <66114686+Martin-Zeithaml@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

build 10574 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/27742557113

@Martin-Zeithaml Martin-Zeithaml changed the title prepare_log_file: update log file creation to use umask for permiss… prepare_log_file: update log file creation to use umask for permissions Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants