Integration tests for cubic and quintic splines with dynamics#1801
Open
srvald wants to merge 2 commits into
Open
Integration tests for cubic and quintic splines with dynamics#1801srvald wants to merge 2 commits into
srvald wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
========================================
+ Coverage 3.59% 5.00% +1.41%
========================================
Files 13 34 +21
Lines 947 4255 +3308
Branches 152 500 +348
========================================
+ Hits 34 213 +179
- Misses 843 4037 +3194
+ Partials 70 5 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where the
passthrough_trajectory_controllerintegration tests were only verifying edge cases (position-only quintic splines with explicit zero-matrices).We now explicitly test the full capabilities of the UR hardware interface regarding custom trajectory profiles.
Changes
test_cubic_trajectory: Test providing positions and zero velocities to evaluate the cubic spline.test_cubic_trajectory_with_velocities: Test providing positions and explicit non-zero velocities to evaluate the cubic spline.test_quintic_trajectory_with_velocities: Verify full quintic spline execution using non-zero velocities and accelerations.Related Issues
Fixes #1783
Testing
Tested via integration testing using
ur_robot_driveralongside Docker URSim:Note
Low Risk
Changes are confined to integration tests in
integration_test_passthrough_controller.py; no driver or controller runtime behavior is modified.Overview
Expands passthrough trajectory controller integration coverage so cubic and quintic spline paths are exercised with more than position-only, all-zero dynamics.
Shared test data now uses a four-waypoint forward-and-return motion (replacing three coarse index steps) and adds
TEST_TRAJECTORY_FULLwith explicit per-waypoint velocities and accelerations. Existing tests that rely onTEST_TRAJECTORYinherit the richer waypoint set and timing.New tests send
FollowJointTrajectorygoals through the passthrough controller and assert success for: cubic splines with zero velocities, cubic with non-zero velocities, and quintic with non-zero velocities and accelerations (alongside the existing quintic-with-zeros case).Reviewed by Cursor Bugbot for commit 7176a82. Bugbot is set up for automated code reviews on this repo. Configure here.