remove mantle_backup_duration_seconds_total metric#169
Merged
Conversation
The values of the metric mantle_backup_duration_seconds_total always are the same as those of mantle_backup_duration_seconds_sum, so we don't need it. This commit removes mantle_backup_duration_seconds_total. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com> Co-authored-by: Yuji Ito <llamerada.jp@gmail.com> Co-authored-by: Kohya Shiozaki <kouyan120706@gmail.com>
ushitora-anqou
force-pushed
the
remove-backup-duration-seconds-total-metric
branch
from
ad26bdd to
2511646
Compare
skoya76
approved these changes
Jun 20, 2025
llamerada-jp
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values of the metric mantle_backup_duration_seconds_total always are
the same as those of mantle_backup_duration_seconds_sum, so we don't
need it. This commit removes mantle_backup_duration_seconds_total.