Skip to content

remove mantle_backup_duration_seconds_total metric #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llamerada-jp merged 1 commit into from
Jun 20, 2025
Merged

remove mantle_backup_duration_seconds_total metric #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,6 @@ make undeploy

## Prometheus metrics

### `mantle_backup_duration_seconds_total`

`mantle_backup_duration_seconds_total` is a Counter that indicates the time from the creationTimestamp to the completion of the backup.

| Label | Description |
| ----------------------- | ----------------------- |
| `persistentvolumeclaim` | The PVC name. |
| `resource_namespace` | The resource namespace. |

### `mantle_mantlebackupconfig_info`

`mantle_mantlebackupconfig_info` is a Gauge that indicates information about the backup configuration.
Expand Down
5 changes: 0 additions & 5 deletions internal/controller/mantlebackup_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,11 +2419,6 @@ func (r *MantleBackupReconciler) primaryCleanup(
}

duration := time.Since(target.GetCreationTimestamp().Time).Seconds()
metrics.BackupDurationSecondsTotal.With(prometheus.Labels{
"persistentvolumeclaim": target.Spec.PVC,
"resource_namespace": target.GetNamespace(),
}).Add(float64(duration))

metrics.BackupDurationSeconds.With(prometheus.Labels{
"persistentvolumeclaim": target.Spec.PVC,
"resource_namespace": target.GetNamespace(),
Expand Down
10 changes: 0 additions & 10 deletions internal/controller/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ import (
const namespace = "mantle"

var (
BackupDurationSecondsTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: namespace,
Name: "backup_duration_seconds_total",
Help: "The time from the creationTimestamp to the completion of the backup.",
},
[]string{"persistentvolumeclaim", "resource_namespace"},
)

BackupConfigInfo = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Namespace: namespace,
Expand All @@ -38,7 +29,6 @@ var (
)

func init() {
runtimemetrics.Registry.MustRegister(BackupDurationSecondsTotal)
runtimemetrics.Registry.MustRegister(BackupConfigInfo)
runtimemetrics.Registry.MustRegister(BackupDurationSeconds)
}
1 change: 0 additions & 1 deletion test/e2e/multik8s/misc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ var _ = Describe("metrics tests", func() {
g.Expect(strings.Contains(string(stdout), metricName)).To(BeTrue())
}).Should(Succeed())
},
Entry(`mantle_backup_duration_seconds_total`, `mantle_backup_duration_seconds_total`),
Entry(`mantle_mantlebackupconfig_info`, `mantle_mantlebackupconfig_info`),
Entry(`mantle_backup_duration_seconds_bucket`, `mantle_backup_duration_seconds_bucket`),
Entry(`mantle_backup_duration_seconds_sum`, `mantle_backup_duration_seconds_sum`),
Expand Down