[v10] Extend global inline code styles

[frankieroberto]

Discovered an issue in nhsuk/nhsuk-service-manual#2585 that <code> elements within a summary list don't get the red-on-white colour.

This fixes that. Also extends the inline code style to where they are within <th> elements.

Before	After

Checklist

• Tested against our testing policy (Resolution, Browser & Accessibility)
• Follows our coding standards and style guide
• CHANGELOG entry

[colinrotherham]

Thanks @frankieroberto

Cache retrieval is failing again (even though it was just saved). Might have to run the actions a few more times—they must be having a slow day again

Am I right in thinking the code block page examples are duplicated?

Once for normal, once for reverse

[frankieroberto]

@colinrotherham duplicated the example into the reverse section now:

[anandamaryon1]

Nice thanks for this @frankieroberto

Should the reverse styles be using nhsuk-code--reverse?

eg. top one here:

[frankieroberto]

@anandamaryon1

Nice thanks for this @frankieroberto

Should the reverse styles be using nhsuk-code--reverse?

Ah good spot. Done in f942a17. It needs the nhsuk-code--inline class adding too for some reason.

Arguably the inverse style could be applied automatically, but that’s a whole other can of worms so maybe leave that for now? (The govuk design system team are looking at this too)

[colinrotherham]

Thanks @frankieroberto 🙌

Just needs a changelog entry?

Probably adjust the PR title to say we're adding global styles (I think we say this?) for inline code elements within table heading, description term and description details elements?

i.e. Whilst it does apply to the summary list these are global styles

[colinrotherham]

Ah good spot. Done in f942a17. It needs the nhsuk-code--inline class adding too for some reason.

Can I have your thoughts on this?

i.e. Should we make <code> global (no parent restrictions) and remove .nhsuk-code--inline?

[frankieroberto]

@colinrotherham:

Can I have your thoughts on this?

i.e. Should we make <code> global (no parent restrictions) and remove .nhsuk-code--inline?

Feels like it could be one for a follow-up PR as we consider global styles more generally? 🤷‍♂️