Skip to content

[v10] Extend global inline code styles #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankieroberto merged 9 commits into from
Jun 29, 2026
Merged

[v10] Extend global inline code styles #1984

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d96c24c
Apply code style in summary lists
frankieroberto Jun 23, 2026
d312866
Add example of code in summary lists
frankieroberto Jun 23, 2026
aa3f3bb
Duplicate block to the reverse section
frankieroberto Jun 23, 2026
c675bf3
Apply code style
frankieroberto Jun 23, 2026
f942a17
Add reverse code classes
frankieroberto Jun 23, 2026
c9be1d5
Update indendation
frankieroberto Jun 23, 2026
e7d45a9
Apply suggestions from code review
frankieroberto Jun 23, 2026
d7e8db4
Add changelog entry
frankieroberto Jun 23, 2026
7b45582
Merge branch 'support/10.x' into apply-code-style-in-summary-lists
frankieroberto Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/nhsuk-frontend-review/src/examples/code-blocks.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,29 @@

<p class="nhsuk-body">This change was introduced in <a class="nhsuk-link nhsuk-link--no-visited-state" href="https://github.com/nhsuk/nhsuk-frontend/pull/1556">pull request #1556: Uplift GOV.UK Frontend file upload component</a>.</p>

<h2>Override classes</h2>
{{ summaryList({
rows: [
{
key: {
html: "<code>nhsuk-u-margin-0</code>",
classes: "nhsuk-u-width-one-half"
},
value: {
text: "Responsive margin on all sides"
}
},
{
key: {
html: "<code>nhsuk-u-margin-top-0</code>"
},
value: {
text: "Responsive margin on the top"
}
}
]
}) }}

</div>
</div>

Expand Down Expand Up @@ -312,6 +335,19 @@

<p class="nhsuk-body">This change was introduced in <a class="nhsuk-link nhsuk-link--reverse nhsuk-link--no-visited-state" href="https://github.com/nhsuk/nhsuk-frontend/pull/1556">pull request #1556: Uplift GOV.UK Frontend file upload component</a>.</p>

<h2>Override classes</h2>
{{ summaryList({
rows: [
{
key: { html: "<code class=\"nhsuk-code--inline nhsuk-code--reverse\">nhsuk-u-margin-0</code>", classes: "nhsuk-u-width-one-half" },
value: { text: "Responsive margin on all sides" }
},
{
key: { html: "<code class=\"nhsuk-code--inline nhsuk-code--reverse\">nhsuk-u-margin-top-0</code>" },
value: { text: "Responsive margin on the top" }
}
] }) }}
Comment thread
colinrotherham marked this conversation as resolved.
Outdated

</div>
</div>

Expand Down
3 changes: 3 additions & 0 deletions packages/nhsuk-frontend/src/nhsuk/core/styles/_typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,9 @@ b {
li code,
caption code,
td code,
th code,
dt code,
dd code,
p code {
width: fit-content;
padding: 2px nhsuk-spacing(1);
Expand Down
Loading