feat: add maxEntityCount param#2224
Conversation
3172a85 to
072312d
Compare
|
Tests on node 24 will fail due to incompatibility with playwright, and raising playwright leads to incompatibility in node 16 and breaks the regression test. Please ask the maintainer to fix the current node 24 tests, as no new commit will pass them. |
|
@mozzie @KTibow @SethFalco will we do something to fix the playwright and nodejs version incompatibility versions? |
072312d to
d578ab3
Compare
d578ab3 to
021535f
Compare
|
Hey @goldserg! Sorry for not acknowledging your PR sooner! All the maintainers are really busy. As you may have seen from our last release, the time we did have available went towards another security advisory that was reported. We'll try to get through PRs/issues soon. 💪(•ᴗ•💪) I can confirm already that the issue is valid, and we will accept a pull request to add the options. It was an oversight on my part to not make a way to disable those checks. Meanwhile, could you please stop pinging maintainers. We get notified of open issues already, pinging us is not going to get your code reviewed any sooner. The bottleneck is availability, and spamming us with notifications just takes up more of the already scarce availability we have! ono
PS: If you look at recent PRs including this one, all of our tests are passing on both Node.js v24 and v16 just fine. This doesn't sound correct, could you elaborate? 🤔 |
I rolled back the changes that were breaking the tests, and now they're all passing |
fixes #2218