Skip to content

feat: add maxEntityCount param#2224

Open
goldserg wants to merge 2 commits into
svg:mainfrom
goldserg:maxEntityCount-v4
Open

feat: add maxEntityCount param#2224
goldserg wants to merge 2 commits into
svg:mainfrom
goldserg:maxEntityCount-v4

Conversation

@goldserg

@goldserg goldserg commented Jun 19, 2026

Copy link
Copy Markdown

fixes #2218

@goldserg

Copy link
Copy Markdown
Author

@mozzie @KTibow @SethFalco

@goldserg
goldserg force-pushed the maxEntityCount-v4 branch 2 times, most recently from 3172a85 to 072312d Compare June 22, 2026 08:55
@goldserg

Copy link
Copy Markdown
Author

Tests on node 24 will fail due to incompatibility with playwright, and raising playwright leads to incompatibility in node 16 and breaks the regression test. Please ask the maintainer to fix the current node 24 tests, as no new commit will pass them.

@goldserg

Copy link
Copy Markdown
Author

@mozzie @KTibow @SethFalco will we do something to fix the playwright and nodejs version incompatibility versions?

@goldserg
goldserg force-pushed the maxEntityCount-v4 branch from 072312d to d578ab3 Compare July 19, 2026 14:05
@goldserg
goldserg force-pushed the maxEntityCount-v4 branch from d578ab3 to 021535f Compare July 19, 2026 14:06
@goldserg

Copy link
Copy Markdown
Author

@mozzie @KTibow @SethFalco

@SethFalco

Copy link
Copy Markdown
Member

Hey @goldserg!

Sorry for not acknowledging your PR sooner! All the maintainers are really busy. As you may have seen from our last release, the time we did have available went towards another security advisory that was reported.

We'll try to get through PRs/issues soon. 💪(•ᴗ•💪)

I can confirm already that the issue is valid, and we will accept a pull request to add the options. It was an oversight on my part to not make a way to disable those checks.

Meanwhile, could you please stop pinging maintainers. We get notified of open issues already, pinging us is not going to get your code reviewed any sooner. The bottleneck is availability, and spamming us with notifications just takes up more of the already scarce availability we have! ono

Tests on node 24 will fail due to incompatibility with playwright, and raising playwright leads to incompatibility in node 16 and breaks the regression test.

PS: If you look at recent PRs including this one, all of our tests are passing on both Node.js v24 and v16 just fine. This doesn't sound correct, could you elaborate? 🤔

@goldserg

Copy link
Copy Markdown
Author

PS: If you look at recent PRs including this one, all of our tests are passing on both Node.js v24 and v16 just fine. This doesn't sound correct, could you elaborate? 🤔

I rolled back the changes that were breaking the tests, and now they're all passing

@KTibow KTibow changed the title feat: add maxEntityCount param #2218 feat: add maxEntityCount param Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add maxEntityCount parameter to sax parser configuration

2 participants